Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Upgrade Reactist to v23.1.0 #59

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore(deps): Upgrade Reactist to v23.1.0 #59

merged 1 commit into from
Jan 31, 2024

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Jan 31, 2024

No description provided.

@gnapse gnapse mentioned this pull request Jan 31, 2024
Closed
@gnapse
Copy link
Contributor Author

gnapse commented Jan 31, 2024

@pawelgrimm, @scottlovegrove what would you recomment we do about the failed check due to npm audit having found a vulnerability with a dependency: @babel/traverse.

I ran npm ls @babel/traverse, and got quite a few direct dependencies through which we get this vulnerable package indirectly:

Details 

❯ npm ls @babel/traverse
root@ /Users/ernesto/code/doist/ui-extensions
├─┬ @doist/[email protected] -> ./packages/ui-extensions-react
│ ├─┬ @storybook/[email protected]
│ │ ├─┬ @storybook/[email protected]
│ │ │ └─┬ @storybook/[email protected]
│ │ │   └─┬ @mdx-js/[email protected]
│ │ │     ├─┬ @babel/[email protected]
│ │ │     │ └── @babel/[email protected] deduped
│ │ │     └─┬ [email protected]
│ │ │       └─┬ @babel/[email protected]
│ │ │         └── @babel/[email protected] deduped
│ │ └─┬ @storybook/[email protected]
│ │   ├─┬ @babel/[email protected]
│ │   │ └─┬ @babel/[email protected]
│ │   │   └── @babel/[email protected] deduped
│ │   └─┬ [email protected]
│ │     └─┬ @babel/[email protected]
│ │       └── @babel/[email protected] deduped
│ ├─┬ @storybook/[email protected]
│ │ ├─┬ @storybook/[email protected]
│ │ │ └─┬ [email protected]
│ │ │   └─┬ @babel/[email protected]
│ │ │     └── @babel/[email protected] deduped
│ │ ├─┬ @storybook/[email protected]
│ │ │ └─┬ @storybook/[email protected]
│ │ │   ├─┬ @storybook/[email protected]
│ │ │   │ └─┬ @storybook/[email protected]
│ │ │   │   └─┬ [email protected]
│ │ │   │     └─┬ @babel/[email protected]
│ │ │   │       └── @babel/[email protected] deduped
│ │ │   ├─┬ @storybook/[email protected]
│ │ │   │ └─┬ [email protected]
│ │ │   │   └─┬ @babel/[email protected]
│ │ │   │     └── @babel/[email protected] deduped
│ │ │   ├─┬ @storybook/[email protected]
│ │ │   │ └── @babel/[email protected] deduped
│ │ │   ├─┬ @storybook/[email protected]
│ │ │   │ └─┬ @storybook/[email protected]
│ │ │   │   └─┬ [email protected]
│ │ │   │     └─┬ @babel/[email protected]
│ │ │   │       └── @babel/[email protected] deduped
│ │ │   └─┬ @storybook/[email protected]
│ │ │     └─┬ @storybook/[email protected]
│ │ │       └─┬ [email protected]
│ │ │         └─┬ @babel/[email protected]
│ │ │           └── @babel/[email protected] deduped
│ │ └─┬ [email protected]
│ │   └─┬ [email protected]
│ │     └─┬ [email protected]
│ │       └── @babel/[email protected] deduped
│ └─┬ @svgr/[email protected]
│   └─┬ @babel/[email protected]
│     └─┬ @babel/[email protected]
│       └─┬ @babel/[email protected]
│         └─┬ @babel/[email protected]
│           └── @babel/[email protected] deduped
├─┬ [email protected]
│ └─┬ @jest/[email protected]
│   └─┬ [email protected]
│     └── @babel/[email protected] deduped
└─┬ [email protected]
  └─┬ @babel/[email protected]
    ├─┬ @babel/[email protected]
    │ └── @babel/[email protected] deduped
    ├─┬ @babel/[email protected]
    │ └── @babel/[email protected] deduped
    └── @babel/[email protected]

Do we need to update them all?

@scottlovegrove
Copy link
Contributor

@gnapse Rebase on main please. I've run audit fixes, plus I noticed our audit check wasn't set to production only (all our other extension repos are set to this).

@gnapse gnapse merged commit 20b6cae into main Jan 31, 2024
3 checks passed
@gnapse gnapse deleted the ernesto/upgrade-reactist branch January 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnapse @scottlovegrove